Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer ManageIQ::Password over legacy MiqPassword constant #20631

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Prefer ManageIQ::Password over legacy MiqPassword constant #20631

merged 1 commit into from
Sep 30, 2020

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Sep 30, 2020

No description provided.

@miq-bot
Copy link
Member

miq-bot commented Sep 30, 2020

Checked commit Fryguy@938bfc3 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
3 files checked, 0 offenses detected
Everything looks fine. 🍪

@agrare agrare self-assigned this Sep 30, 2020
@agrare agrare merged commit bf28fa0 into ManageIQ:master Sep 30, 2020
@agrare agrare added the core label Sep 30, 2020
@kbrock
Copy link
Member

kbrock commented Oct 3, 2020

this is where it all begins...

@Fryguy Fryguy deleted the legacy_miq_password branch October 29, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@gtanzillo gtanzillo Awaiting requested review from gtanzillo

@kbrock kbrock Awaiting requested review from kbrock kbrock is a code owner

Assignees

@agrare agrare

Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fryguy @miq-bot @kbrock @agrare